tag:blogger.com,1999:blog-8221886912876606828.post6965603786000991344..comments2023-06-23T00:44:05.938-07:00Comments on Elided Branches: Code Reviews, Code StoriesCamille Fournierhttp://www.blogger.com/profile/05090020862261633248noreply@blogger.comBlogger5125tag:blogger.com,1999:blog-8221886912876606828.post-29851452695169955372012-07-03T12:52:15.046-07:002012-07-03T12:52:15.046-07:00Automated coverage tools (cobertura) for the most ...Automated coverage tools (cobertura) for the most part. They're not perfect but definitely give a good overview. I do also encourage people to review anyone's checkins as they feel necessary and definitely when fixing a hard bug to make sure they've thought through corner cases.Camille Fournierhttps://www.blogger.com/profile/05090020862261633248noreply@blogger.comtag:blogger.com,1999:blog-8221886912876606828.post-87391891623949938652012-07-03T12:39:59.088-07:002012-07-03T12:39:59.088-07:00Out of curiosity - how do you make sure that you h...Out of curiosity - how do you make sure that you have adequate test coverage? Oftentimes that's one of the major roles that code reviews take on; not just reviewing the code, but having someone else's eyes on the tests to see if the original developer missed any cases they should be testing.Amberhttps://www.blogger.com/profile/16380301210358899228noreply@blogger.comtag:blogger.com,1999:blog-8221886912876606828.post-32470467037656626122012-06-23T12:55:28.566-07:002012-06-23T12:55:28.566-07:00Related to the Power Hour, I've instituted the...Related to the Power Hour, I've instituted the Testing Clinic (our global team of 90+ developers is deficient in 1) above). This is a weekly where a developer can ask for help on "how to test this bit of code I've got?". Egos are (hopefully) suppressed since there's very little testing done anyway ( :( ), and it becomes an opportunity to tap into isolated expertise, or to create a problem-solving dialogue. More importantly, I think it creates a culture of testing. Hopefully, over time, the need for such a clinic will decline as developers will come together as needed. But for now, our biggest problem is scheduling this weekly - Friday mornings (NY) seems most attractive to East Coasters, but horrible for the India staff (Friday evenings!). Every other day seems jam-packed with other global meetings.<br /><br />Re. code reviews: much as they've been despised for all the reasons you cite, I recall reading somewhere that they still catch a LOT of the the most egregious bugs in code - human code reviewers (with the right attitude) still do better than complete reliance on unit tests :)Mike Mhttps://www.blogger.com/profile/11490344190768803850noreply@blogger.comtag:blogger.com,1999:blog-8221886912876606828.post-41303509927896547342012-06-22T11:45:13.619-07:002012-06-22T11:45:13.619-07:00I'm glad you enjoyed it! I hope that it works ...I'm glad you enjoyed it! I hope that it works as well for your team as it has for ours.Camille Fournierhttps://www.blogger.com/profile/05090020862261633248noreply@blogger.comtag:blogger.com,1999:blog-8221886912876606828.post-77539036439094250392012-06-22T10:08:55.262-07:002012-06-22T10:08:55.262-07:00Thanks for this! I shared it with our team of deve...Thanks for this! I shared it with our team of developers who deal with "Challenge #2" on a daily basis and I got some very positive feedback.Camille Aceyhttps://www.blogger.com/profile/08088945478653638179noreply@blogger.com